-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [release-1.6] Set linkchecker base branch to release-1.6 #10359
🌱 [release-1.6] Set linkchecker base branch to release-1.6 #10359
Conversation
Signed-off-by: Sunnatillo <sunnat.samadov@est.tech>
Hi @Sunnatillo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Good catch!
Did this cause an issue somewhere? We should probably document that this change is needed in the release documentation.
It is documented here. But we somehow missed it last time. I do not think this caused any issues |
Wondering if there are dead links at the release-1.6 branch we may can already fix :D |
/lgtm To be honest. Nobody cares about broken links in the release-1.6 branch now. Let's fix them only if they pop up. |
LGTM label has been added. Git tree hash: e3ab8916446632bca71aea0ed5c8a891b82481d0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(IIRC the periodic job was still working correctly for release-1.6: https://github.com/kubernetes-sigs/cluster-api/actions/runs/8507802203) |
What this PR does / why we need it:
This PR sets linkchecker base branch to release-1.6
/area ci